Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CURA-11887] Fuzzy Skin Outside Only: Make definition of 'inside' user-settable #2113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Commits on Jul 3, 2024

  1. Fuzzy skin: Allow 'inside' to be not just definite 2d holes.

    Expand the 'only fuzzy in outside' setting to also mean things the user reasonably could consider inside, instead of just completely closed holes. Take the (approximate) convex hull of the shape, take the difference to get candidate parts that could be considered to be inside of the shape -- then, for each part, determine where it touches the outside. The ratio between how much 'outside' outline and total outline of such a shape (as well as a general size of the hole if ther _is_ any 'outside') determines if points on the polygon thouching that part (outside of the original polygon but inside the approx convex hull) will get 'fuzzed' or not.
    
    part of CURA-11887
    rburema committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f7f10f8 View commit details
    Browse the repository at this point in the history
  2. Applied clang-format.

    rburema authored and github-actions[bot] committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9f6afd3 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Use new settings for 'inside' detection fuzzy-skin outside-only.

    Also make the ratio always true even when 0 by replacing < with <=, so fully enclosed areas don't get fuzzed/jittered ever if outside only is on.
    
    part CURA-11887
    rburema committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    1e48764 View commit details
    Browse the repository at this point in the history