Fixing Default Thread Count Calculation #35
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I discussed in #34, the Smooth Boot wiki states that Smooth Boot's default Main Worker Thread Count is
1/2 of total CPU threads
. However, the auto-generated default value I found in my config.json
was not consistent with this stated intention.I suspected that the wiki stated the plan or intention, but the code was inconsistent with this plan, so I looked through the code to find where the default values were generated.
I found it.
I propose that we change the code to reflect the sensible plan set forth in the wiki.