Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WebView #484

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

This file was deleted.

1 change: 0 additions & 1 deletion UltraStar Play/Assets/Common/Common.asmdef
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"playsharedui",
"SpleeterSharp",
"UnityStandaloneFileBrowser",
"Vuplex.WebView",
"LiteNetLib",
"com.whisper.unity",
"FfmpegUnity",
Expand Down
6 changes: 1 addition & 5 deletions UltraStar Play/Assets/Common/Graphics/SongMetaImageUtils.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

public static class SongMetaImageUtils
{
private static YouTubeCoverImageProvider youTubeCoverImageProvider = new();

public static IObservable<string> GetBackgroundOrCoverImageUri(SongMeta songMeta)
{
string uri = SongMetaUtils.GetBackgroundUri(songMeta);
Expand Down Expand Up @@ -54,9 +52,7 @@ public static IObservable<string> GetCoverOrBackgroundImageUri(SongMeta songMeta
}

// Try to find an image via mods
List<ISongCoverImageProvider> songCoverImageProviders = ModManager.GetModObjects<ISongCoverImageProvider>()
.Union(new List<ISongCoverImageProvider>() { youTubeCoverImageProvider })
.ToList();
List<ISongCoverImageProvider> songCoverImageProviders = ModManager.GetModObjects<ISongCoverImageProvider>();
if (songCoverImageProviders.IsNullOrEmpty())
{
return Observable.Return("");
Expand Down
110 changes: 0 additions & 110 deletions UltraStar Play/Assets/Common/Graphics/YouTubeCoverImageProvider.cs

This file was deleted.

This file was deleted.

5 changes: 0 additions & 5 deletions UltraStar Play/Assets/Common/Model/Settings/Settings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,6 @@ public class Settings : ISettings
public Dictionary<string, List<HttpApiPermission>> HttpApiPermissions { get; set; } = new();
public int CompanionClientMessageBufferTimeInMillis { get; set; } = 150;

// WebView settings
public List<string> AcceptedWebViewHosts { get; set; } = new();
public bool EnableWebView { get; set; } = true;
public string CustomUserAgent { get; set; } = "";

// Other settings
public PartyModeSettings PartyModeSettings { get; set; } = new();
public SongEditorSettings SongEditorSettings { get; set; } = new();
Expand Down
Loading
Loading