hardcode lua array size #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IMaxPlayerCount, they currently just happen to be the same value
barbeque-squared
force-pushed
the
hardcode-lua-array-size
branch
from
689882b to
ef3003a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the array size for the lua functions has no relation whatsoever with IMaxPlayerCount, they currently just happen to be the same value
this is a similar change to what was done in #554, specifically #554 (comment)
I don't think it's wrong to use a hardcoded number here: it's a static array, it seems to be how Pascal works, it's done hundreds of other times throughout the code -- see for example UIni.pas.
And maybe there is an even better way, but at the very least, I think this PR objectively improves the code.