remove 8 and 12 player options from the player selection screen #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbeque-squared
force-pushed
the
disable-8-and-12-players
branch
from
bd924e2 to
f1a12f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented on #634, specifically #634 (comment), 8 and 12 players have never worked at any point in USDX history.
This PR removes the 8 and 12 player options from the player select screen altogether.
EDIT: as the also added TODO suggests: I did not touch the internal IMaxPlayerCount. I don't have the time to figure out which of the 100+ usages is causing issues, and it's one of those things that might just get accidentally fixed during a refactoring.
(I did not have much time in the second half of 2024 to continue the refactoring)