Support Video Files That Contain Embedded Artwork #948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some file formats (notably MP4), FFmpeg uses an
AVStream
structure to logically represent embedded cover art. USDX's current video stream selection logic always selects the first video stream reported by FFmpeg. If the first video stream is cover art, USDX will fail to play the video. See #902.FFmpeg sets a flag
AV_DISPOSITION_ATTACHED_PIC
to indicate that anAVStream
object represents cover art. This PR updates the stream selection logic to reject video streams that have the flag set. This ensures that an actual video stream will be selected for files that contain embedded cover art.Fixes #902