Restore 2.3.1 version check (part 2) #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
Miepee
reviewed
Jul 12, 2024
| else | ||
| { | ||
| if (reader.ReadUInt32() == 0) // At all points (besides the first one) | ||
| reader.undertaleData.SetGMS2Version(2, 3, 1); // if BezierX0 equals to 0 (the above check) |
There was a problem hiding this comment.
Suggested change
| reader.undertaleData.SetGMS2Version(2, 3, 1); // if BezierX0 equals to 0 (the above check) | |
| reader.undertaleData.SetGMS2Version(2, 3, 1); // If BezierX0 equals to 0 (the above check) |
|
I thought there were more issues floating around for this one? |
Co-authored-by: Miepee <[email protected]>
Jacky720
approved these changes
Jul 12, 2024
Miepee
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #1696; this just moves the check to the object count unserialization stage, preventing the warning that can occur otherwise. Closes #1414.
Notes
I think it's OK that this can potentially yield false positives/negatives, as the original PR says, because newer GM versions bypass this check altogether.