Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually add DEBUG constant to nightly builds #1893

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Conversation

colinator27
Copy link
Member

Description

It seems that the updater button has completely vanished from nightly/bleeding edge builds, presumably because DEBUG isn't being defined correctly. Not sure if we should apply this to other workflows, too.

Caveats

Not sure if there's some other configuration thing I'm missing, or if this is how the compiler is meant to work.

Copy link

github-actions bot commented Aug 27, 2024

Copy link
Contributor

@Miepee Miepee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems wrong, the -c configuration should already handle DEBUG being set.
Maybe it needs to be -c DEBUG instead of -c Debug?

@colinator27
Copy link
Member Author

This seems wrong, the -c configuration should already handle DEBUG being set. Maybe it needs to be -c DEBUG instead of -c Debug?

I don't think so, the configuration name should be Debug. Not sure what's supposed to control DEBUG being defined, but it's definitely not in any project files right now. Some docs on https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/preprocessor-directives suggest that it should be defined automatically, but it's clearly not happening right now. Maybe it's just an IDE thing for some reason?

@Miepee Miepee merged commit cbb70ca into master Dec 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants