Fix edge case with 2024.6+ masks #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request here: GUI:
CLI: |
|
Going to merge this in now so that downstream PRs (mostly 2024.11) have access to it (and this is pretty small). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2033. However, note that the game for that issue is in 2024.11, so these changes will need to be pulled downstream for this to fully affect that game.
It seems that certain sprites in 2024.6, such as empty sprites, will produce bounding boxes that are inverted, which creates negative collision mask width/height values... This causes weird behavior, with collision masks being generated at strange sizes from negative calculations (the negatives coincidentally cancel each other out, giving a positive mask length).
Caveats
This may break some scripts depending on
uintrather thanint, but I did a search to fix as many as I could. I also updatedUndertaleSprite.NewMaskEntryto take inUndertaleData, so that it can account for 2024.6 as well.Notes
I also added two
FIXMEs for the import graphics scripts that have not yet accounted for 2024.6, but that can come in later PRs.