Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lodash._isEqual for checking eeObject equality #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kylebarron
Copy link
Contributor

Currently we use === for checking if EE objects are identical. EE objects are a sort of JS object under the hood. This means that this is true:

const eeObject = ee.Image('CGIAR/SRTM90_V4');
eeObject === eeObject // true

but this isn't:

ee.Image('CGIAR/SRTM90_V4') === ee.Image('CGIAR/SRTM90_V4');
// false

This PR uses lodash.isEqual for checking deep equality of EE objects. This prevents unnecessarily creating new map objects when the referenced dataset is the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant