Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added credits page #117

Closed
wants to merge 8 commits into from
Closed

Added credits page #117

wants to merge 8 commits into from

Conversation

muuvmuuv
Copy link
Contributor

@muuvmuuv muuvmuuv commented Jul 8, 2018

On this page, we can give credit to authors. I added those two for the new logo.

@Glavin001 Glavin001 self-requested a review July 8, 2018 16:16
Copy link
Member

@Glavin001 Glavin001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can merge once the logo has been added to the website. You can add in this PR.

@Glavin001 Glavin001 requested a review from stevenzeck July 8, 2018 16:17
@muuvmuuv
Copy link
Contributor Author

muuvmuuv commented Jul 9, 2018

@Glavin001 done. I‘m working on a new website design, should I open an issue for that or just a pr when I‘m done (or partly)?

@muuvmuuv muuvmuuv closed this Jul 9, 2018
@muuvmuuv
Copy link
Contributor Author

muuvmuuv commented Jul 9, 2018

Oops I accidentally closed it...

@muuvmuuv muuvmuuv reopened this Jul 9, 2018
@Glavin001
Copy link
Member

@muuvmuuv I'd prefer to hold out for a big change until your redesign is implemented:

image

Then we can do everything together, such as I'll go update the logo in other appropriate places, too.

You can implement your redesign in this PR.

@Glavin001 Glavin001 mentioned this pull request Jul 10, 2018
@Glavin001
Copy link
Member

@muuvmuuv I created an issue to discuss the logo: #120
And another for the website design: #121

From here on, please use GitHub's smart comments in your commit messages: https://help.github.com/articles/closing-issues-using-keywords/
For example, Close #120. Updated the logo and See #121. Work on website redesign then Close #121. Complete website redesign, etc.

@@ -1,5 +1,5 @@
- caption: "Unibeautify"
image: "img/unibeautify.png"
image: "img/signet.svg"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer the name be img/unibeautify.svg.

@Glavin001
Copy link
Member

Closing as a duplicate of #122 . Will continue there.

@Glavin001 Glavin001 closed this Jul 12, 2018
@Glavin001
Copy link
Member

@muuvmuuv Please merge this branch into your other PR, if you have not already. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants