feat: minimal delegation storage #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Feb 18, 2025
snreynolds
reviewed
Feb 18, 2025
src/MinimalDelegation.sol
Outdated
| bytes32 private constant MINIMAL_DELEGATION_STORAGE_LOCATION = | ||
| 0x21f3d48e9724698d61a2dadd352c365013ee5d0f841f7fc54fb8a78301ee0c00; | ||
|
|
||
| function _getMinimalDelegationStorage() private pure returns (MinimalDelegationStorage storage $) { |
There was a problem hiding this comment.
can we put this in a library?
so like the syntax here would be keyStorage.get()? i remember sometimes this is tricky but worth a shot
snreynolds
reviewed
Feb 18, 2025
src/MinimalDelegation.sol
Outdated
| bytes32 private constant MINIMAL_DELEGATION_STORAGE_LOCATION = | ||
| 0x21f3d48e9724698d61a2dadd352c365013ee5d0f841f7fc54fb8a78301ee0c00; | ||
|
|
||
| function _getMinimalDelegationStorage() private pure returns (MinimalDelegationStorage storage $) { |
There was a problem hiding this comment.
also where did the $ notation come from is that standard? i find it hard to read lol
snreynolds
reviewed
Feb 18, 2025
snreynolds
reviewed
Feb 20, 2025
snreynolds
reviewed
Feb 20, 2025
snreynolds
reviewed
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.