Chore: bump v2-sdk to 3.2.3 in sor #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeki
approved these changes
Oct 18, 2023
|
Tested this change in routing-api via local tarball, and confirm that routing-api integ-test from https://github.com/Uniswap/routing-api/pull/396/files can pass on my local https://app.warp.dev/block/YexGH1ltEvgDmcKxqIIz2V |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Release Chore: bump version to 3.2.3 v2-sdk#149
What is the current behavior? (You can also link to an open issue here)
Prior to ship Update SOR to let v2-sdk handle the FOT calculation #421, web FOT quote has double FOT taxation issue, hence Update SOR to let v2-sdk handle the FOT calculation #421 was needed.
What is the new behavior (if this is a feature change)?
After shipping Update SOR to let v2-sdk handle the FOT calculation #421, web FOT quote no longer has double FOT taxation issue. However if the token in is FOT, then the exact-in quote will be larger than the actual swap, and such swap failure rate will increase. For example, BLASTER => WETH swap success rate drops after shipping Update SOR to let v2-sdk handle the FOT calculation #421, where before shipping Update SOR to let v2-sdk handle the FOT calculation #421, BLASTER => WETH swap success rate was high, but MEV exploitation was non-trivial, with entire BLASTER sell tax of 3.5% being potential MEV profit for those MEV bots.
Other information:
enhanced unit test https://github.com/Uniswap/smart-order-router/pull/432/files#diff-6660508267e42e2a466452dc3fb55415357900c3644f0af744b343e512c07978L170-R175, such that the test would've failed if this regression is not fixed yet.
added FOT integ-test in SOR, that largely resembles routing-ai FOT integ-test from https://github.com/Uniswap/routing-api/blob/09a40a0a9a40ad0881337decd0db9a43ba39f3eb/test/mocha/integ/quote.test.ts#L1046-L1203