Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Fix: FOT token tax retrieval source #148

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented Oct 17, 2023

We noticed a regression in the Uniswap/smart-order-router#421 for FOT quote - if the token in is FOT, SOR no longer deducts the FOT tax off the quote. Note in the PR, how the first outputAmountWithSellFeeBps was passed into v2-sdk Pair.getOutputAmount(inputAmount). Then the PR changed to pass in outputAmount into v2-sdk Pair.getOutputAmount(inputAmount).

@jsy1218 jsy1218 requested a review from mikeki October 17, 2023 22:00
@jsy1218 jsy1218 self-assigned this Oct 17, 2023
@jsy1218 jsy1218 requested a review from cgkol October 17, 2023 22:01
@jsy1218 jsy1218 merged commit d8c05dd into main Oct 17, 2023
7 checks passed
@jsy1218 jsy1218 deleted the jsy1218/fix-fot-token-tax-retrieval-source branch October 17, 2023 22:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants