Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add UniswapV4DeployerCompetition #117

Merged
merged 31 commits into from
Nov 8, 2024
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
d02ba21
feat: add UniswapV4DeployerCompetition
marktoda Jun 4, 2024
246abe3
merge main
dianakocsis Sep 30, 2024
cf4c612
add comments
dianakocsis Oct 4, 2024
5db7a3a
change scoring to discuss
dianakocsis Oct 7, 2024
1af2165
interface plus tests
dianakocsis Oct 7, 2024
e8a4854
inheritdoc tags
dianakocsis Oct 7, 2024
0bbf0dc
change scoring algorithm
dianakocsis Oct 11, 2024
5966068
feat: remove prizes
marktoda Oct 17, 2024
1549749
Merge branch 'main' into add-deployer
marktoda Oct 17, 2024
663b019
feat: add natspec
marktoda Oct 17, 2024
c744963
fix: snaps
marktoda Oct 17, 2024
07657f4
feat: improve test
marktoda Oct 17, 2024
d70e668
feat: cleanup scoring code
marktoda Oct 18, 2024
ef02200
Merge branch 'main' into add-deployer
marktoda Oct 18, 2024
a7bfb24
fix: typo
marktoda Oct 18, 2024
1a27be0
Merge branch 'main' into add-deployer
hensha256 Nov 1, 2024
7ee4dea
update constructor parameters for pool manager
hensha256 Nov 1, 2024
81791ba
correct snapshots
hensha256 Nov 1, 2024
58fa41b
Include address in salt
hensha256 Nov 1, 2024
e56c8b7
remove console logs
hensha256 Nov 1, 2024
5e38cb8
correct test name
hensha256 Nov 1, 2024
f7b60a7
More constructor parameters
hensha256 Nov 1, 2024
46557ec
fix: remove override keywords
marktoda Nov 6, 2024
17a81bf
fix: remove unused code
marktoda Nov 6, 2024
bc20985
fix: use default create2 function signature
marktoda Nov 6, 2024
f788998
feat: remove unused import
marktoda Nov 6, 2024
8055ecb
fix: remove unused v4Owner variable
marktoda Nov 6, 2024
df948e3
fix: add rules to natspec
marktoda Nov 6, 2024
fbd1596
fix(deployComp): remove bestaddress storage
marktoda Nov 7, 2024
1a7f117
fix: minor nits
marktoda Nov 7, 2024
66b91ce
snapshot
hensha256 Nov 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: improve test
marktoda committed Oct 17, 2024
commit 07657f4fb9f2da95da82a3ef4f61409fc414872c
1 change: 1 addition & 0 deletions test/UniswapV4DeployerCompetition.t.sol
Original file line number Diff line number Diff line change
@@ -44,6 +44,7 @@ contract UniswapV4DeployerCompetitionTest is Test {
emit IUniswapV4DeployerCompetition.NewAddressFound(newAddress, winner, VanityAddressLib.score(newAddress));
competition.updateBestAddress(salt);
assertFalse(competition.bestAddress() == address(0));
assertEq(competition.bestAddress(), newAddress);
assertEq(competition.bestAddressSubmitter(), winner);
assertEq(competition.bestAddressSalt(), salt);
address v4Core = competition.bestAddress();