Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settle pair #242

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Settle pair #242

merged 6 commits into from
Aug 2, 2024

Conversation

dianakocsis
Copy link
Contributor

Related Issue

add settle_pair command

Copy link
Collaborator

@saucepoint saucepoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a first pass, will look at tests more closely later

@saucepoint saucepoint added the posm position manager label Aug 1, 2024
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks goooood thanks for all the comparison tests to close!

@@ -0,0 +1 @@
150178
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! down from 150926 when using close

Copy link
Collaborator

@saucepoint saucepoint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good minus the collision

@saucepoint saucepoint merged commit a9e463d into main Aug 2, 2024
3 checks passed
@saucepoint saucepoint deleted the settle-pair branch August 2, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
posm position manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants