Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync before native settle #364

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Sync before native settle #364

merged 5 commits into from
Nov 21, 2024

Conversation

hensha256
Copy link
Contributor

No description provided.

373899
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprising and SAD

@hensha256 hensha256 requested a review from snreynolds October 15, 2024 19:12
snreynolds
snreynolds previously approved these changes Oct 16, 2024
Copy link
Member

@snreynolds snreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I would love to see a test though

saucepoint
saucepoint previously approved these changes Nov 21, 2024
marktoda
marktoda previously approved these changes Nov 21, 2024
@hensha256 hensha256 dismissed stale reviews from marktoda and saucepoint via a639f6f November 21, 2024 21:02
@hensha256 hensha256 merged commit b3b7c49 into main Nov 21, 2024
3 checks passed
@hensha256 hensha256 deleted the sync-native branch November 21, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants