feat: add Wrapped Staked Eth hook #451
Conversation
|
no license identifier in this file |
| /// @param wrappedAmount Desired amount of wstETH | ||
| /// @return Amount of stETH required | ||
| /// @dev Uses current stETH/wstETH exchange rate for calculation | ||
| function _getWrapInputRequired(uint256 wrappedAmount) internal view override returns (uint256) { |
There was a problem hiding this comment.
i might just be thinking about this differently, but wouldn't it make more sense if this was called _getUnwrapInputRequired instead? Because you are specifying the amount of wrapped token that you want and this function is calculating how much of the unwrapped token you need to input
There was a problem hiding this comment.
I'm thinking of it as - we're calling the operation wrap and want the result to be wrappedAmount. What's the input required to wrap operation to get wrappedAmount -> thus get wrap input required
There was a problem hiding this comment.
oh i see: its the input to the wrap function
|
|
||
| /// @notice Required to receive ETH from unwrapping operations | ||
| /// @dev Needed for protocol integrations that might send ETH to this contract | ||
| receive() external payable {} |
There was a problem hiding this comment.
last question: when would this be needed?
There was a problem hiding this comment.
oop leftover from weth hook
Related Issue
Which issue does this pull request resolve?
Description of changes