-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch optimism testnet from kovan to goerli #217
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,9 +46,9 @@ export const USDC_OPTIMISM = new Token( | |
'USDC', | ||
'USD//C' | ||
) | ||
export const USDC_OPTIMISTIC_KOVAN = new Token( | ||
SupportedChainId.OPTIMISTIC_KOVAN, | ||
'0x3b8e53b3ab8e01fb57d0c9e893bc4d655aa67d84', | ||
export const USDC_OPTIMISM_GOERLI = new Token( | ||
SupportedChainId.OPTIMISM_GOERLI, | ||
'0x7E07E15D2a87A24492740D16f5bdF58c16db0c4E', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Where did you pull this address from? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is a usdc contract i deployed to unblock another team for testing: https://goerli-optimism.etherscan.io/address/0x7e07e15d2a87a24492740d16f5bdf58c16db0c4e#code currently it's our canonical usdc token on optimism goerli https://github.com/ethereum-optimism/ethereum-optimism.github.io/blob/bf1d49a8cd99db70beb7ff8d7adb6fb9c22f1b78/optimism.tokenlist.json#L1870-L1880 |
||
6, | ||
'USDC', | ||
'USD//C' | ||
|
@@ -115,7 +115,7 @@ export const USDC: { [chainId in SupportedChainId]: Token } = { | |
[SupportedChainId.ARBITRUM_ONE]: USDC_ARBITRUM, | ||
[SupportedChainId.OPTIMISM]: USDC_OPTIMISM, | ||
[SupportedChainId.ARBITRUM_RINKEBY]: USDC_ARBITRUM_RINKEBY, | ||
[SupportedChainId.OPTIMISTIC_KOVAN]: USDC_OPTIMISTIC_KOVAN, | ||
[SupportedChainId.OPTIMISM_GOERLI]: USDC_OPTIMISM_GOERLI, | ||
[SupportedChainId.POLYGON]: USDC_POLYGON, | ||
[SupportedChainId.POLYGON_MUMBAI]: USDC_POLYGON_MUMBAI, | ||
[SupportedChainId.GOERLI]: USDC_GOERLI, | ||
|
@@ -281,8 +281,8 @@ export const WRAPPED_NATIVE_CURRENCY: { [chainId: number]: Token | undefined } = | |
'WETH', | ||
'Wrapped Ether' | ||
), | ||
[SupportedChainId.OPTIMISTIC_KOVAN]: new Token( | ||
SupportedChainId.OPTIMISTIC_KOVAN, | ||
[SupportedChainId.OPTIMISM_GOERLI]: new Token( | ||
SupportedChainId.OPTIMISM_GOERLI, | ||
'0x4200000000000000000000000000000000000006', | ||
18, | ||
'WETH', | ||
|
@@ -370,7 +370,7 @@ export const TOKEN_SHORTHANDS: { [shorthand: string]: { [chainId in SupportedCha | |
[SupportedChainId.ARBITRUM_ONE]: USDC_ARBITRUM.address, | ||
[SupportedChainId.OPTIMISM]: USDC_OPTIMISM.address, | ||
[SupportedChainId.ARBITRUM_RINKEBY]: USDC_ARBITRUM_RINKEBY.address, | ||
[SupportedChainId.OPTIMISTIC_KOVAN]: USDC_OPTIMISTIC_KOVAN.address, | ||
[SupportedChainId.OPTIMISM_GOERLI]: USDC_OPTIMISM_GOERLI.address, | ||
[SupportedChainId.POLYGON]: USDC_POLYGON.address, | ||
[SupportedChainId.POLYGON_MUMBAI]: USDC_POLYGON_MUMBAI.address, | ||
[SupportedChainId.GOERLI]: USDC_GOERLI.address, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does this symbol come from? Why does this use ö instead of oe, like the rest of the labels?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goerli in this same file uses the symbol, copypastaed here for consistency
widgets/src/constants/chainInfo.ts
Line 93 in e434298