fix: lock jotai version to 1.4.0 #555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcinciarka is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
marcinciarka
changed the title
piotrkonowrocki
approved these changes
Mar 13, 2023
vm
approved these changes
Mar 13, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
we'll re-run the tests and then merge this 👍 |
Merged
just-toby
approved these changes
Mar 13, 2023
|
https://github.com/Uniswap/widgets/releases/tag/v2.47.10 should solve your issue. unfortunately, this branch's tests keep failing for an unknown reason, so i merged the same diff in #556. we'll figure that out separately. thanks for the effort here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
"jotai": "^1.3.7"works well when testing with the react-cosmos stack cause it's using the locked version from the projectyarn.lockfile (which is 1.4.0). When using the widget somewhere else (eg. anywhere tbh) it's using the newer version (1.13.1) which is not compatible.This PR makes sure that the proper version (exact same as when running the project from this repo) is used and will resolve this issue: #374