Add --fuzzing-ratio to CLI #2496
Conversation
1. Fix error with classloader 2. Add an option to control fuzzer ration
Markoutte
added
ctg-enhancement
| @@ -149,9 +148,12 @@ class GenerateTestsCommand : | |||
| projectRootPath == null -> { | |||
| println("The path to the project root is required to generate a report. Please, specify \"--project-root\" option.") | |||
| } | |||
| sourceCodeFile == null -> { | |||
There was a problem hiding this comment.
I am not sure if we need curly braces here )
| @@ -149,9 +148,12 @@ class GenerateTestsCommand : | |||
| projectRootPath == null -> { | |||
| println("The path to the project root is required to generate a report. Please, specify \"--project-root\" option.") | |||
There was a problem hiding this comment.
May be we should not ask specifying but suggest specifying the source code. Otherwise the user may think that it is mandatory for proper work of utility.
There was a problem hiding this comment.
The --project-root is mandatory only when --sarif is set. In others cases it is not mandatory
| @@ -131,14 +125,20 @@ abstract class GenerateTestsAbstractCommand(name: String, help: String) : | |||
| .long() | |||
| .default(LONG_GENERATION_TIMEOUT) | |||
|
|
|||
| private val fuzzingRation by option( | |||
There was a problem hiding this comment.
Nit: "ration" seems misused here. Consider calling this property fuzzingRatio instead of fuzzingRation.
| private val fuzzingRation by option( | ||
| "--fuzzing-ratio", | ||
| help = "Specify the ratio between symbolic engine and fuzzing" | ||
| ) | ||
| .double() |
There was a problem hiding this comment.
According to this comment from @tyuldashev, the default is 0.1 fuzzing, 0.9 symbolic. If we take the help text literally, then the default "ratio between symbolic engine and fuzzing" would be 0.9 ÷ 0.1 = 9. But from my understanding of the code, 9 is not a valid value here, and this argument should actually be 0.1 to mimic the default behavior.
Consider revising this option's name and help text to reflect its actual semantics and to document its default behavior. For example:
private val fuzzingFraction by option(
"-z",
"--fuzzing-fraction",
help = "Specifies the fraction of time spent using fuzzing instead of the symbolic engine (default: $DEFAULT_FUZZING_VALUE)"
)
.double()
.default(DEFAULT_FUZZING_VALUE)
.validate { require(it in 0.0 .. 1.0) { "should be between 0.0 and 1.0." } }where DEFAULT_FUZZING_VALUE is the default value of org.utbot.framework.plugin.api.TestFlow.fuzzingValue: currently 0.1.
Description
--sourceoption is absent then no javadocs is generatedSelf-check list