Make thread stopping in ThreadBasedExecutor
more safe
#2503
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously
ThreadBasedExecutor
:ThreadDeath
was caught bykotlin.runCatching
)thread
to die before starting a new one, causing race conditionstop()
a thread even during clean up operations, causingjava.lang.IllegalStateException: Cannot start new transaction without ending existing transaction
How to test
Manual tests
Generate integration tests for
OrderService
fromspring-boot-testing
project with low hanging test time out.There should be no
Caused by: java.lang.IllegalStateException: Cannot start new transaction without ending existing transaction
.Some time out tests should generate.
Self-check list