-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure EtsIR is more three-address-like #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## neo #245 +/- ##
============================================
+ Coverage 59.43% 59.51% +0.08%
Complexity 2240 2240
============================================
Files 309 309
Lines 18301 18288 -13
Branches 3261 3260 -1
============================================
+ Hits 10877 10885 +8
+ Misses 6349 6329 -20
+ Partials 1075 1074 -1 ☔ View full report in Codecov by Sentry. |
CaelmBleidd
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to ensure that EtsIR is three-address code by adding the
ensureOneAddress
function toArkIR -> EtsIR
conversion process (inConvert.kt
). This function extracts nested expressions and field/array references by assigning them to temp locals. In fact, the proposed functionality was already present here, but was duplicated in multiple places. This PR both generalizes it in one place, and also handles nested RHVs inAssignStmt
.