Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure EtsIR is more three-address-like #245

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Ensure EtsIR is more three-address-like #245

merged 4 commits into from
Aug 2, 2024

Conversation

Lipen
Copy link
Collaborator

@Lipen Lipen commented Jul 26, 2024

This PR proposes to ensure that EtsIR is three-address code by adding the ensureOneAddress function to ArkIR -> EtsIR conversion process (in Convert.kt). This function extracts nested expressions and field/array references by assigning them to temp locals. In fact, the proposed functionality was already present here, but was duplicated in multiple places. This PR both generalizes it in one place, and also handles nested RHVs in AssignStmt.

@Lipen Lipen requested a review from CaelmBleidd July 26, 2024 08:02
Copy link
Contributor

github-actions bot commented Jul 26, 2024

Test results on JDK 19

   83 files  ±0     83 suites  ±0   25m 35s ⏱️ -1s
2 511 tests ±0  2 469 ✅ ±0  42 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 497 ✅ ±0  42 💤 ±0  0 ❌ ±0 

Results for commit 8bc63bc. ± Comparison against base commit 864759b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 26, 2024

Test results on JDK 8

   83 files  ±0     83 suites  ±0   33m 22s ⏱️ +7s
2 511 tests ±0  2 466 ✅ ±0  45 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 494 ✅ ±0  45 💤 ±0  0 ❌ ±0 

Results for commit 8bc63bc. ± Comparison against base commit 864759b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 26, 2024

Test results on JDK 11

   83 files  ±0     83 suites  ±0   30m 37s ⏱️ -2s
2 511 tests ±0  2 471 ✅ ±0  40 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 499 ✅ ±0  40 💤 ±0  0 ❌ ±0 

Results for commit 8bc63bc. ± Comparison against base commit 864759b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jul 26, 2024

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 53s ⏱️ +2s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 8bc63bc. ± Comparison against base commit 864759b.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.51%. Comparing base (864759b) to head (8bc63bc).

Files Patch % Lines
...-ets/src/main/kotlin/org/jacodb/ets/dto/Convert.kt 92.85% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #245      +/-   ##
============================================
+ Coverage     59.43%   59.51%   +0.08%     
  Complexity     2240     2240              
============================================
  Files           309      309              
  Lines         18301    18288      -13     
  Branches       3261     3260       -1     
============================================
+ Hits          10877    10885       +8     
+ Misses         6349     6329      -20     
+ Partials       1075     1074       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lipen Lipen merged commit 4164b3c into neo Aug 2, 2024
10 checks passed
@Lipen Lipen deleted the lipen/3ac branch August 2, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants