Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid global synchronization #247

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Avoid global synchronization #247

merged 1 commit into from
Aug 5, 2024

Conversation

Saloed
Copy link
Collaborator

@Saloed Saloed commented Jul 31, 2024

Since ASM nodes are mutable, any operation requires synchronization. Currently we use global synchronization in flowGraph which significantly affects performance in a concurrent environment.

Copy link
Contributor

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 56s ⏱️ +3s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit f5e77cd. ± Comparison against base commit 4b15fc6.

Copy link
Contributor

Test results on JDK 19

   83 files  ±0     83 suites  ±0   27m 7s ⏱️ -23s
2 511 tests ±0  2 469 ✅ ±0  42 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 497 ✅ ±0  42 💤 ±0  0 ❌ ±0 

Results for commit f5e77cd. ± Comparison against base commit 4b15fc6.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.05%. Comparing base (4b15fc6) to head (f5e77cd).

Files Patch % Lines
...in/kotlin/org/jacodb/impl/cfg/MethodNodeBuilder.kt 88.88% 0 Missing and 1 partial ⚠️
...mpl/features/classpaths/virtual/JcVirtualMethod.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #247      +/-   ##
============================================
+ Coverage     60.03%   60.05%   +0.01%     
+ Complexity     2244     2242       -2     
============================================
  Files           310      310              
  Lines         18122    18131       +9     
  Branches       3259     3260       +1     
============================================
+ Hits          10880    10889       +9     
  Misses         6164     6164              
  Partials       1078     1078              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Test results on JDK 11

   83 files  ±0     83 suites  ±0   30m 19s ⏱️ -6s
2 511 tests ±0  2 471 ✅ ±0  40 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 499 ✅ ±0  40 💤 ±0  0 ❌ ±0 

Results for commit f5e77cd. ± Comparison against base commit 4b15fc6.

Copy link
Contributor

Test results on JDK 8

   83 files  ±0     83 suites  ±0   30m 45s ⏱️ - 1m 47s
2 511 tests ±0  2 466 ✅ ±0  45 💤 ±0  0 ❌ ±0 
2 539 runs  ±0  2 494 ✅ ±0  45 💤 ±0  0 ❌ ±0 

Results for commit f5e77cd. ± Comparison against base commit 4b15fc6.

@Saloed Saloed requested a review from CaelmBleidd July 31, 2024 13:57
@Saloed Saloed merged commit 00164e3 into neo Aug 5, 2024
12 checks passed
@Saloed Saloed deleted the saloed/fix-synchronization branch August 5, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants