Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DOT dump for Ets files #251

Merged
merged 22 commits into from
Aug 6, 2024
Merged

Refactor DOT dump for Ets files #251

merged 22 commits into from
Aug 6, 2024

Conversation

rudolf101
Copy link
Member

No description provided.

@rudolf101 rudolf101 requested a review from Lipen August 5, 2024 12:56
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Test results on JDK 19

   83 files     83 suites   26m 55s ⏱️
2 512 tests 2 470 ✅ 42 💤 0 ❌
2 540 runs  2 498 ✅ 42 💤 0 ❌

Results for commit 096a599.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Test results on JDK 8

   83 files  ±0     83 suites  ±0   33m 39s ⏱️ + 4m 13s
2 512 tests +1  2 467 ✅ +1  45 💤 ±0  0 ❌ ±0 
2 540 runs  +1  2 495 ✅ +1  45 💤 ±0  0 ❌ ±0 

Results for commit 096a599. ± Comparison against base commit 4164b3c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Test results on JDK 11

   83 files  ±0     83 suites  ±0   31m 36s ⏱️ + 2m 16s
2 512 tests +1  2 472 ✅ +1  40 💤 ±0  0 ❌ ±0 
2 540 runs  +1  2 500 ✅ +1  40 💤 ±0  0 ❌ ±0 

Results for commit 096a599. ± Comparison against base commit 4164b3c.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 56s ⏱️ -1s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 9f40d3f. ± Comparison against base commit 4164b3c.

♻️ This comment has been updated with latest results.

@rudolf101 rudolf101 changed the title Implement ets loading with dot dump Refactor DOT dump for Ets files Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 30.49645% with 98 lines in your changes missing coverage. Please review.

Project coverage is 60.02%. Comparing base (4164b3c) to head (096a599).
Report is 1 commits behind head on neo.

Files Patch % Lines
...-ets/src/main/kotlin/org/jacodb/ets/utils/Utils.kt 8.64% 69 Missing and 5 partials ⚠️
...-ets/src/main/kotlin/org/jacodb/ets/dto/Convert.kt 0.00% 9 Missing ⚠️
...rc/main/kotlin/org/jacodb/ets/utils/LoadEtsFile.kt 75.00% 6 Missing and 1 partial ⚠️
...ain/kotlin/org/jacodb/ets/utils/EtsFileDtoToDot.kt 0.00% 2 Missing and 1 partial ⚠️
...c/main/kotlin/org/jacodb/ets/utils/EtsFileToDot.kt 0.00% 2 Missing and 1 partial ⚠️
...db-ets/src/main/kotlin/org/jacodb/ets/utils/Dot.kt 88.23% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #251      +/-   ##
============================================
+ Coverage     59.51%   60.02%   +0.50%     
+ Complexity     2240     2238       -2     
============================================
  Files           309      311       +2     
  Lines         18288    18413     +125     
  Branches       3260     3265       +5     
============================================
+ Hits          10885    11053     +168     
+ Misses         6329     6272      -57     
- Partials       1074     1088      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Lipen Lipen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Lipen Lipen merged commit c2d57d2 into neo Aug 6, 2024
4 checks passed
@Lipen Lipen deleted the rudolf101/ets-to-dot branch August 6, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants