-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix locations in intermediate statements #253
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## neo #253 +/- ##
============================================
+ Coverage 59.53% 59.55% +0.01%
Complexity 2238 2238
============================================
Files 309 309
Lines 18297 18313 +16
Branches 3261 3261
============================================
+ Hits 10894 10906 +12
- Misses 6329 6333 +4
Partials 1074 1074 ☔ View full report in Codecov by Sentry. |
CaelmBleidd
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some spurious locations mismatches by extracting the recursive calls (such as
EtsAssignStmt(location = loc(), lhv = <recurse>, rhv = <recurse>)
) withensureOneAddress
inside them. Without extracting these sub-expressions,loc()
produces a location that might be "reused" by anotherloc()
call insideensureOneAddress
(which creates extra assignment statement for complex expressions, thus allocates and fills a location). The proper way of doing it is to ensure thatlhv
andrhv
are computed (and all necessary extra statements are already created and put insidecurrentStmts
) before callingloc()
for the newly created statement.In fact, not all extractions that were made in this PR are strictly necessary for the correctness, but I just made the code changes uniform and consistent.