Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to match the current ArkAnalyzer #255

Merged
merged 11 commits into from
Aug 8, 2024
Merged

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Aug 6, 2024

This PR introduces some changes that are necessary to upgrade to the current version of ArkAnalyzer.

  • Bump ArkAnalyzer, switch to using a special neo-branch in the fork.
  • Update JSON dumps of ArkIR for samples.
  • Remove fields initializers. They were moved (as a list of assignments: this.field := value) into the special @instance_init method.
  • Make MethodDto.body nullable since it might be absent.
  • Support AwaitExpr and YieldExpr.
  • Rename CallableType to FunctionType.
  • Add JsonElement inside UnknownValueDto.
  • Add empty CFG. EtsMethod returns empty CFG when it does not have one.
  • Use kotlin("test") for Kotlin-style assertions in tests.

Remove fields initializers (moved into special init method).
Make Method's body nullable since it might be absent.
Bump ArkAnalyzer, switch to using a special neo-branch in the fork.
Update JSON dumps of ArkIR for samples.
Use kotlin("test") for Kotlin-style assertions in tests.
@Lipen Lipen requested a review from CaelmBleidd August 6, 2024 09:23
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 53s ⏱️ -1s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit 7c135ea. ± Comparison against base commit f24d98b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Test results on JDK 19

   83 files  ±0     83 suites  ±0   14m 23s ⏱️ -38s
2 510 tests  - 2  2 469 ✅  - 3  41 💤 +1  0 ❌ ±0 
2 538 runs   - 2  2 497 ✅  - 3  41 💤 +1  0 ❌ ±0 

Results for commit 7c135ea. ± Comparison against base commit f24d98b.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 39.37008% with 77 lines in your changes missing coverage. Please review.

Project coverage is 59.81%. Comparing base (f24d98b) to head (7c135ea).

Files Patch % Lines
...ain/kotlin/org/jacodb/ets/utils/EtsFileDtoToDot.kt 46.51% 14 Missing and 9 partials ⚠️
...b-ets/src/main/kotlin/org/jacodb/ets/dto/Values.kt 22.22% 14 Missing ⚠️
...ets/src/main/kotlin/org/jacodb/ets/base/EtsExpr.kt 7.14% 13 Missing ⚠️
...-ets/src/main/kotlin/org/jacodb/ets/utils/Utils.kt 0.00% 11 Missing ⚠️
...-ets/src/main/kotlin/org/jacodb/ets/dto/Convert.kt 67.74% 5 Missing and 5 partials ⚠️
...rc/main/kotlin/org/jacodb/ets/utils/GetOperands.kt 0.00% 2 Missing ⚠️
...ets/src/main/kotlin/org/jacodb/ets/base/EtsType.kt 50.00% 1 Missing ⚠️
...db-ets/src/main/kotlin/org/jacodb/ets/dto/Types.kt 0.00% 1 Missing ⚠️
...ets/src/main/kotlin/org/jacodb/ets/graph/EtsCfg.kt 0.00% 1 Missing ⚠️
.../src/main/kotlin/org/jacodb/ets/model/EtsMethod.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #255      +/-   ##
============================================
- Coverage     60.14%   59.81%   -0.33%     
- Complexity     2250     2251       +1     
============================================
  Files           312      312              
  Lines         18472    18491      +19     
  Branches       2940     2945       +5     
============================================
- Hits          11110    11061      -49     
- Misses         6268     6334      +66     
- Partials       1094     1096       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Test results on JDK 11

   83 files  ±0     83 suites  ±0   16m 22s ⏱️ +19s
2 510 tests  - 2  2 471 ✅  - 3  39 💤 +1  0 ❌ ±0 
2 538 runs   - 2  2 499 ✅  - 3  39 💤 +1  0 ❌ ±0 

Results for commit 7c135ea. ± Comparison against base commit f24d98b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Test results on JDK 8

   83 files  ±0     83 suites  ±0   20m 53s ⏱️ + 2m 44s
2 510 tests  - 2  2 466 ✅  - 3  44 💤 +1  0 ❌ ±0 
2 538 runs   - 2  2 494 ✅  - 3  44 💤 +1  0 ❌ ±0 

Results for commit 7c135ea. ± Comparison against base commit f24d98b.

♻️ This comment has been updated with latest results.

@rudolf101 rudolf101 self-requested a review August 8, 2024 12:26
Copy link
Member

@rudolf101 rudolf101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 This code shines brighter than my future. Ready for merge!

@Lipen Lipen merged commit 3661d03 into neo Aug 8, 2024
9 of 11 checks passed
@Lipen Lipen deleted the lipen/update-arkanalyzer branch August 8, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants