Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate local test resources via Gradle task #258

Merged
merged 16 commits into from
Aug 16, 2024
Merged

Generate local test resources via Gradle task #258

merged 16 commits into from
Aug 16, 2024

Conversation

Lipen
Copy link
Member

@Lipen Lipen commented Aug 8, 2024

This PR proposes to start relying on local test resources (JSON dumps of EtsIR, etc) that can be generated via generateTestResource Gradle task.

In addition, this PR includes some updates for DOT generation and PDF rendering for samples (all local test resources), see DumpEtsFilesToDot in Entrypoints.kt.

@Lipen Lipen requested review from rudolf101 and CaelmBleidd August 8, 2024 16:20
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Test results on JDK 19

   83 files  ±0     83 suites  ±0   15m 46s ⏱️ + 1m 1s
2 510 tests ±0  2 469 ✅ ±0  41 💤 ±0  0 ❌ ±0 
2 538 runs  ±0  2 497 ✅ ±0  41 💤 ±0  0 ❌ ±0 

Results for commit a054327. ± Comparison against base commit 3661d03.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Test results on JDK 8

   83 files  ±0     83 suites  ±0   20m 55s ⏱️ - 1m 19s
2 510 tests ±0  2 466 ✅ ±0  44 💤 ±0  0 ❌ ±0 
2 538 runs  ±0  2 494 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit a054327. ± Comparison against base commit 3661d03.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Test results on JDK 11

   83 files  ±0     83 suites  ±0   15m 48s ⏱️ -12s
2 510 tests ±0  2 471 ✅ ±0  39 💤 ±0  0 ❌ ±0 
2 538 runs  ±0  2 499 ✅ ±0  39 💤 ±0  0 ❌ ±0 

Results for commit a054327. ± Comparison against base commit 3661d03.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 56s ⏱️ +2s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit a054327. ± Comparison against base commit 3661d03.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.81%. Comparing base (3661d03) to head (a054327).
Report is 3 commits behind head on neo.

Files Patch % Lines
...rc/main/kotlin/org/jacodb/ets/utils/LoadEtsFile.kt 0.00% 1 Missing ⚠️
...-ets/src/main/kotlin/org/jacodb/ets/utils/Utils.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #258      +/-   ##
============================================
- Coverage     59.81%   59.81%   -0.01%     
  Complexity     2251     2251              
============================================
  Files           312      312              
  Lines         18491    18492       +1     
  Branches       2945     2945              
============================================
  Hits          11061    11061              
- Misses         6334     6335       +1     
  Partials       1096     1096              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rudolf101 rudolf101 self-requested a review August 9, 2024 14:32
Copy link
Member

@rudolf101 rudolf101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 If only all code were this smooth. Merging now!

@Lipen Lipen merged commit 29d5df0 into neo Aug 16, 2024
10 of 11 checks passed
@Lipen Lipen deleted the lipen/resources branch August 16, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants