Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown classes fields #260

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fix unknown classes fields #260

merged 1 commit into from
Aug 14, 2024

Conversation

Saloed
Copy link
Collaborator

@Saloed Saloed commented Aug 14, 2024

[jacodb-core] Force use of UnknownClassMethodsAndFields conditionally

If the UnknownClasses classpath feature is configured to be used, then force use of the UnknownClassMethodsAndFields feature as well.

[jacodb-core] Run IRTest with the UnknownClasses feature

Added dependency on the commons-compress 1.21 which requires the UnknownClasses feature.

[jacodb-core] Avoid using try {} catch (e: Exception) {}

[jacodb-core] Add and use JcClasspath.registeredLocationIds

[jacodb-core] Run ClassesTest with in-RAM backend

If the UnknownClasses classpath feature is configured to be used, then
force use of the UnknownClassMethodsAndFields feature as well.

[jacodb-core] Run IRTest with the UnknownClasses feature

Added dependency on the commons-compress 1.21 which requires
the UnknownClasses feature.

[jacodb-core] Avoid using `try {} catch (e: Exception) {}`

[jacodb-core] Add and use JcClasspath.registeredLocationIds

[jacodb-core] Run ClassesTest with in-RAM backend
Copy link
Contributor

Lifecycle test results

78 tests  ±0   78 ✅ ±0   1m 56s ⏱️ +2s
 7 suites ±0    0 💤 ±0 
 7 files   ±0    0 ❌ ±0 

Results for commit b945a2e. ± Comparison against base commit 3661d03.

Copy link
Contributor

Test results on JDK 11

   83 files  ±0     83 suites  ±0   15m 58s ⏱️ -2s
2 512 tests +2  2 473 ✅ +2  39 💤 ±0  0 ❌ ±0 
2 540 runs  +2  2 501 ✅ +2  39 💤 ±0  0 ❌ ±0 

Results for commit b945a2e. ± Comparison against base commit 3661d03.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.87%. Comparing base (3661d03) to head (b945a2e).

Files Patch % Lines
.../src/main/kotlin/org/jacodb/impl/JcDatabaseImpl.kt 87.50% 0 Missing and 1 partial ⚠️
.../main/kotlin/org/jacodb/impl/bytecode/KMetadata.kt 75.00% 0 Missing and 1 partial ⚠️
...ain/kotlin/org/jacodb/impl/features/Diagnostics.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                neo     #260      +/-   ##
============================================
+ Coverage     59.81%   59.87%   +0.05%     
- Complexity     2251     2257       +6     
============================================
  Files           312      312              
  Lines         18491    18490       -1     
  Branches       2945     2947       +2     
============================================
+ Hits          11061    11070       +9     
+ Misses         6334     6327       -7     
+ Partials       1096     1093       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Test results on JDK 8

   83 files  ±0     83 suites  ±0   20m 20s ⏱️ - 1m 54s
2 512 tests +2  2 468 ✅ +2  44 💤 ±0  0 ❌ ±0 
2 540 runs  +2  2 496 ✅ +2  44 💤 ±0  0 ❌ ±0 

Results for commit b945a2e. ± Comparison against base commit 3661d03.

Copy link
Contributor

Test results on JDK 19

   83 files  ±0     83 suites  ±0   14m 46s ⏱️ -1s
2 512 tests +2  2 471 ✅ +2  41 💤 ±0  0 ❌ ±0 
2 540 runs  +2  2 499 ✅ +2  41 💤 ±0  0 ❌ ±0 

Results for commit b945a2e. ± Comparison against base commit 3661d03.

@Saloed Saloed requested a review from CaelmBleidd August 14, 2024 10:43
@Saloed Saloed merged commit fce4d81 into neo Aug 14, 2024
12 checks passed
@Saloed Saloed deleted the saloed/unknown-classes-fix branch August 14, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants