Fix unknown classes and ERS API improvement #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[jacodb-core] Specify identity for UnknownField, UnknownMethod, JcTypedFieldImpl [jacodb-core] Fix operations with map names in LmdbKeyValueStorage [jacodb-core] Avoid creation of named maps for R/O operations [jacodb-core] Force use of sortedSet by getMapNames() [jacodb-core] For an entity type, add ability to get names of used properties/blobs/links The sets of names of properties/blobs/links returned by the API consist of names ever have been set to an entity of specified type. So the sets can contain names of properties/blobs/links that could actually have been deleted in all entities of specified type. As a bonus, the way how named map are created was changed. As of now, any R/O operation doesn't implicitly create name map, whereas R/W operation does. TODO: fix implementation atop of LMDB and SQLite. [jacodb-core] Define equals()/hashcode() in JcUnknownClass & JcUnknownType [jacodb-core] Apply JcUnknownClassLookup only for instances of JcUnknownClass As of now, there is no longer an ability to get and unknown field or an unknown method for instances other than JcUnknownClass. [jacodb-api] ERS API: inherit EntityIterable from Kotlin Sequence As of now, EntityIterable is no longer Iterable, but Kotlin Sequence. All methods and properties, except iterator(), have default implementations. Binary operations are implemented as lazy sequences.
Test results on JDK 19 84 files 84 suites 13m 50s ⏱️ Results for commit f63c31d. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[jacodb-core] Specify identity for UnknownField, UnknownMethod, JcTypedFieldImpl
[jacodb-core] Fix operations with map names in LmdbKeyValueStorage
[jacodb-core] Avoid creation of named maps for R/O operations
[jacodb-core] Force use of sortedSet by getMapNames()
[jacodb-core] For an entity type, add ability to get names of used properties/blobs/links
The sets of names of properties/blobs/links returned by the API consist of names ever have been set to an entity of specified type. So the sets can contain names of properties/blobs/links that could actually have been deleted in all entities of specified type.
As a bonus, the way how named map are created was changed. As of now, any R/O operation doesn't implicitly create name map, whereas R/W operation does.
TODO: fix implementation atop of LMDB and SQLite.
[jacodb-core] Define equals()/hashcode() in JcUnknownClass & JcUnknownType
[jacodb-core] Apply JcUnknownClassLookup only for instances of JcUnknownClass
As of now, there is no longer an ability to get and unknown field or an unknown method for instances other than JcUnknownClass.
[jacodb-api] ERS API: inherit EntityIterable from Kotlin Sequence
As of now, EntityIterable is no longer Iterable, but Kotlin Sequence. All methods and properties, except iterator(), have default implementations. Binary operations are implemented as lazy sequences.