TS symbolic machine expansion #200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zishkaz
commented
Jul 29, 2024
zishkaz
commented
- TSExprResolver skeleton with TSSimpleValueResolver
- TSTypeSystem
- TSInterpreter skeleton
CaelmBleidd
requested changes
Jul 29, 2024
| @@ -44,3 +45,30 @@ class TSComponents( | |||
| closeableResources.forEach(AutoCloseable::close) | |||
| } | |||
| } | |||
|
|
|||
| class TSFpSortSizeExprProvider( | |||
There was a problem hiding this comment.
Why do we need this class? It is just a copy of UBVSizeProvider. Moreover, why is it called "fp"?
Comment on lines
+22
to
+30
| fun typeToSort(type: EtsType): USort = when (type) { | ||
| is EtsAnyType -> addressSort | ||
| is EtsVoidType -> voidSort | ||
| is EtsUndefinedType -> undefinedSort | ||
| is EtsRefType -> addressSort | ||
| is EtsBooleanType -> boolSort | ||
| is EtsNumberType -> fp64Sort | ||
| is EtsStringType -> stringSort | ||
| else -> error("Unknown type: $type") |
There was a problem hiding this comment.
Thius This contain less types than actual hierarchy
Comment on lines
+74
to
+76
| // stmt.nextStmt?.let { nextStmt -> | ||
| // scope.doWithState { newStmt(nextStmt) } | ||
| // } |
There was a problem hiding this comment.
These are too complicated changes to be made like this. I expect to have a separate PR with lot of tests for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.