Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual calls #43

Merged
merged 19 commits into from
Aug 8, 2023
Merged

Virtual calls #43

merged 19 commits into from
Aug 8, 2023

Conversation

sergeypospelov
Copy link
Member

@sergeypospelov sergeypospelov commented Jul 24, 2023

Go to this for reviewing changes (GitHub is laggy)

The PR introduces the initial support of virtual calls in JcInterpreter. Also, it fixes some issues and adds optimizations in type regions.

Details

Minor

  • Updated JacoDB version to 1.2.0 to get the last fixes
  • Added an optimization to UTypeRegion, for constraints on the exact type
  • Changed the default path selector strategy to PathSelectionStrategy.FORK_DEPTH, because it works better with virtual invokes
  • Fixed bug in BfsPathSelector

PR TODOs:

  • Add tests
  • Refactor
  • Comments
  • Description

@sergeypospelov sergeypospelov changed the base branch from main to sergey/instanceof July 24, 2023 14:24
@sergeypospelov sergeypospelov changed the base branch from sergey/instanceof to main July 25, 2023 08:45
@sergeypospelov sergeypospelov changed the base branch from main to sergey/instanceof July 25, 2023 08:46
@sergeypospelov sergeypospelov force-pushed the sergey/virtual_calls branch 2 times, most recently from d1b0886 to 9a92abf Compare July 26, 2023 17:09
@sergeypospelov sergeypospelov changed the base branch from sergey/instanceof to main July 26, 2023 17:09
@sergeypospelov sergeypospelov changed the base branch from main to tochilinak/python July 26, 2023 17:16
@sergeypospelov sergeypospelov changed the base branch from tochilinak/python to main July 26, 2023 17:16
@sergeypospelov sergeypospelov changed the title WIP: Virtual calls Virtual calls Jul 28, 2023
@Saloed Saloed self-requested a review August 7, 2023 14:51
Copy link
Collaborator

@Saloed Saloed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Saloed Saloed requested a review from CaelmBleidd August 7, 2023 16:04
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaelmBleidd CaelmBleidd merged commit c9e9675 into main Aug 8, 2023
1 check passed
@sergeypospelov sergeypospelov deleted the sergey/virtual_calls branch August 21, 2023 07:14
@sergeypospelov sergeypospelov mentioned this pull request Aug 21, 2023
57 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants