-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual calls #43
Merged
Merged
Virtual calls #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeypospelov
force-pushed
the
sergey/virtual_calls
branch
2 times, most recently
from
July 26, 2023 17:09
d1b0886
to
9a92abf
Compare
sergeypospelov
force-pushed
the
sergey/virtual_calls
branch
from
July 28, 2023 15:30
3f11349
to
500360c
Compare
Saloed
force-pushed
the
sergey/virtual_calls
branch
from
August 7, 2023 14:08
500360c
to
efca282
Compare
Saloed
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
CaelmBleidd
approved these changes
Aug 8, 2023
Damtev
approved these changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to this for reviewing changes (GitHub is laggy)
The PR introduces the initial support of virtual calls in
JcInterpreter
. Also, it fixes some issues and adds optimizations in type regions.Details
Minor
1.2.0
to get the last fixesUTypeRegion
, for constraints on the exact typePathSelectionStrategy.FORK_DEPTH
, because it works better with virtual invokesBfsPathSelector
PR TODOs: