Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NetworkManager not returning correct LocalClientId on server side [MTT-5387] #2398

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Jan 30, 2023

This resolves the issue where NetworkManager.LocalClientId returning the NetworkTransport.ServerClientId when running as a server or host.
#2395
MTT-5387

Changelog

  • Fixed: issue where NetworkManager.LocalClientId was returning the NetworkTransport.ServerClientId as opposed to the NetworkManager.m_LocalClientId.

Testing and Documentation

  • No tests have been added.

The NGO ServerClientId should be assigned when starting the server and should be used to return the correct LocalClientId (NGO Layer) on the server or host side.
changelog update
updating changelog entry to reflect the PR associated with it.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review January 30, 2023 17:50
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner January 30, 2023 17:50
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) January 31, 2023 00:28
@NoelStephensUnity NoelStephensUnity merged commit f6d3a58 into develop Jan 31, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/networkmanager-localclientid-return-value-server-side branch January 31, 2023 00:43
@NoelStephensUnity NoelStephensUnity changed the title fix: NetworkManager not returning correct LocalClientId on server side fix: NetworkManager not returning correct LocalClientId on server side [MTT-5387] Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants