Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Load and Chunked Save of Demo Files #5455

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Jul 14, 2021

Proposed change(s)

Adds two new IL improvements: allow for adding additional .demo files during a training run, and saves new demos from the DemonstrationWriter in chunks of Num Steps to Record size.

You can combine these two features to do online IL by pointing the writer and the GAIL/BC YAML to the same folder, but no explicit way of doing online has been added.

Also fixed a longstanding bug that if multiple demo files are in a folder, they are all treated as one long appended file, which is not correct as the final obs/action pair will be joined with the first one from the next file.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng marked this pull request as ready for review August 19, 2021 01:30
@miguelalonsojr miguelalonsojr requested review from miguelalonsojr and removed request for vincentpierre January 18, 2022 23:43
@miguelalonsojr miguelalonsojr self-assigned this Jan 18, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Ervin Teng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants