-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tips in docs #5566
base: main
Are you sure you want to change the base?
Add tips in docs #5566
Conversation
|
@maryamhonari or @jrupert-unity can you have a look at this PR? Seems reasonable since it's a doc update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make some good improvements, but need work.
I would remove the change around line 234.
I'd remove line 270 and change 272&273 to use actionBuffers.ContinuousActions[]. Same with 319&320.
Line 264 should say ContinuousActions[] or actionBuffers.ContinuousActions[].
Line 443 should be "Make sure the behavior name in the 'Behavior Parameters' component matches the one in the config file." to fix spelling and punctuation.
Hey I am very new to OS contributions. I cannot see any options to edit the code in my pull request. |
I think if you push more changes to the file the pull request will update. Alternatively if Miguel approves we can accept this pull request and I can update with my changes after that.
|
Alright, I'll do that Edit: done |
Proposed change(s)
I updated a code block and added little tips to explain things better, ones I wish were included when I was first learning from the docs.
Types of change(s)
Checklist
Other comments