Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to PettingZoo homepage #6065

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Update links to PettingZoo homepage #6065

merged 1 commit into from
Mar 6, 2024

Conversation

alex-mccarthy-unity
Copy link
Collaborator

Proposed change(s)

This new website was introduced in the docs for PettingZoo 1.21.0 in 2022: https://pypi.org/project/pettingzoo/1.21.0/ (compare to https://pypi.org/project/pettingzoo/1.20.1/ )

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

This new website was introduced in the docs for PettingZoo 1.21.0 in 2022: https://pypi.org/project/pettingzoo/1.21.0/
(compare to https://pypi.org/project/pettingzoo/1.20.1/ )
Copy link
Collaborator

@miguelalonsojr miguelalonsojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alex-mccarthy-unity alex-mccarthy-unity merged commit 3fc8d8e into Unity-Technologies:develop Mar 6, 2024
8 checks passed
@alex-mccarthy-unity alex-mccarthy-unity deleted the update-pettingzoo-link branch March 6, 2024 13:56
alex-mccarthy-unity added a commit that referenced this pull request Mar 6, 2024
* Specify python 3.10.12 for nightly runs

Both ml-agents and ml-agents-envs only allow Python versions <=3.10.12: make sure the nightly uses a valid version.

(We might want to consider allowing any 3.10 version so that we can be using the latest security bugfixes, such as 3.10.13: https://www.python.org/downloads/release/python-31013/ )

Sample failure of nightly full-pytest before: https://github.com/alex-mccarthy-unity/ml-agents/actions/runs/8152427823/job/22281884176
Sample passing run afterwards: https://github.com/alex-mccarthy-unity/ml-agents/actions/runs/8153333182/job/22284499278

* Fix dead links in documentation

Together with #6065, fix the `markdown-link-check-full` component of nightly runs.

Sample failing run before: https://github.com/alex-mccarthy-unity/ml-agents/actions/runs/8152427823/job/22281884377
Sample passing run after: https://github.com/alex-mccarthy-unity/ml-agents/actions/runs/8154489456/job/22288022888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants