Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum numpy version to 1.23.5 to fix installation errors on windows #6081

Closed
wants to merge 1 commit into from

Conversation

alex-mccarthy-unity
Copy link
Collaborator

@alex-mccarthy-unity alex-mccarthy-unity commented Mar 13, 2024

Proposed change(s)

Fixes the following errors when installing ml-agents-envs on windows if numpy 1.21.2 is already installed:

  Building wheel for numpy (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for numpy (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [326 lines of output]
      setup.py:63: RuntimeWarning: NumPy 1.21.2 may not yet support Python 3.10.
        warnings.warn(
      Running from numpy source directory.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Fixes #6047

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe) dependency upgrade

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

…indows

Fixes #6047

Fixes the following errors when installing ml-agents-envs on windows if numpy 1.21.2 is already installed:
```
  Building wheel for numpy (pyproject.toml) ... error
  error: subprocess-exited-with-error

  × Building wheel for numpy (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [326 lines of output]
      setup.py:63: RuntimeWarning: NumPy 1.21.2 may not yet support Python 3.10.
        warnings.warn(
      Running from numpy source directory.
```
@alex-mccarthy-unity alex-mccarthy-unity changed the base branch from develop to fix-editor-version-ci March 13, 2024 13:23
@delete-merged-branch delete-merged-branch bot deleted the branch fix-editor-version-ci March 13, 2024 17:23
Copy link
Collaborator

@miguelalonsojr miguelalonsojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@miguelalonsojr
Copy link
Collaborator

@alex-mccarthy-unity Please rebase w/main (do not merge main in) and then we should be good.

@alex-mccarthy-unity
Copy link
Collaborator Author

@alex-mccarthy-unity Please rebase w/main (do not merge main in) and then we should be good.

Rebased onto develop and pushed.

But GitHub is still claiming there are conflicts to resolve, while showing "Recent push is still being processed, and will show up in a bit", which I've never seen before:
Screenshot 2024-03-13 at 22 07 42

I hope this won't last for many hours, like the report in https://github.com/orgs/community/discussions/78775 . In the mean time, I'll likely check in on this tomorrow.

@alex-mccarthy-unity
Copy link
Collaborator Author

@alex-mccarthy-unity Please rebase w/main (do not merge main in) and then we should be good.

Rebased onto develop and pushed.

But GitHub is still claiming there are conflicts to resolve, while showing "Recent push is still being processed, and will show up in a bit", which I've never seen before: Screenshot 2024-03-13 at 22 07 42

I hope this won't last for many hours, like the report in https://github.com/orgs/community/discussions/78775 . In the mean time, I'll likely check in on this tomorrow.

I still see "processing updates" an hour later, so I re-sent this as #6082

@miguelalonsojr
Copy link
Collaborator

Closing PR in favor of #6082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release-21-branch numpy can't install successful.
2 participants