UUM-87263 Fix issue where macOS machines set to Morocco/Casablanca timezone were one hour behind #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source from this fix from coreclr dotnet/runtime#458
|
|
bholmes
reviewed
Dec 20, 2024
| else | ||
| // pulled in from this fix | ||
| // https://github.com/dotnet/runtime/pull/458/ | ||
| AdjustmentRule? r = !string.IsNullOrEmpty(futureTransitionsPosixFormat) ? |
There was a problem hiding this comment.
You have run into a problem with AdjustmentRule being nullable. As it is a reference type, you may not need to add the ?. Does the commit work without it?
bholmes
approved these changes
Dec 20, 2024
|
Actually you need some info filled out in the PR description section. The release notes section and backports section needs filled out. You will also need to create more PRs for backport branches, but land this first. |
UnityAlex
requested changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sourced from this fix from coreclr dotnet/runtime#458
More info on the fix context in this comment:
dotnet/runtime#31331 (comment)
Reviewers: please consider these questions as well! ❤️
Release notes
Fixed UUM-XXXXXX @username:
Mono: Your release notes go here.