Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gongwen
Copy link

@gongwen gongwen commented Sep 12, 2022

1。The callback of onUnityAdsFailedToLoad and onUnityAdsShowFailure should be dispatched in main thread。
2。Fix the exception escape caused by using ExecutorService.submit。
When using ExecutorService.submit, if it is not handled properly, it may cause an exception to escape. For example: only call the method, but do not handle its exception

The following is the official document introduction:https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadPoolExecutor.html

Note: When actions are enclosed in tasks (such as FutureTask) either explicitly or via methods such as submit, these task objects catch and maintain computational exceptions, and so they do not cause abrupt termination, and the internal exceptions are not passed to this method.

1。The callback of onUnityAdsFailedToLoad and onUnityAdsShowFailure should be dispatched in main thread。
2。Fix the exception escape caused by using ExecutorService.submit。
@gzjaychen
Copy link

gzjaychen commented Aug 22, 2024

@UnitySteven @TinaHanAtUnity
Please check the proguard of android Unity Ads 4.12.2

-keep public class * {
*;
}

It will keep all the classes of the whole project and increase the apk size.

@zhaidw
Copy link

zhaidw commented Aug 23, 2024

@UnitySteven @TinaHanAtUnity Please check the proguard of android Unity Ads 4.12.2

-keep public class * { *; }

It will keep all the classes of the whole project and increase the apk size.

Yes, I found same bug for my android not obfuscated by Unity Ads 4.12.2

@Jun19
Copy link

Jun19 commented Sep 2, 2024

@UnitySteven @TinaHanAtUnity Please check the proguard of android Unity Ads 4.12.2

-keep public class * { *; }

It will keep all the classes of the whole project and increase the apk size.

fix it plz @DeclanMcPartlin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants