Backend upgrade 4.x #175
Open
Backend upgrade 4.x #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: montesm <[email protected]>
Signed-off-by: montesm <[email protected]>
|
This will be a nice QOL enhancement 👍 I've tried to use a record so many times only to remember that we're on java 11. |
Signed-off-by: montesm <[email protected]>
Signed-off-by: montesm <[email protected]>
Signed-off-by: montesm <[email protected]>
Signed-off-by: montesm <[email protected]>
This reverts commit 8d3a767 Signed-off-by: montesm <[email protected]>
Signed-off-by: montesm <[email protected]>
Signed-off-by: montesm <[email protected]>
montesmoci
commented
Mar 20, 2024
| private List<ServiceDefinitionAttributeDTO> buildUserResponseAttributesFromRequest(HttpRequest<?> request, List<ServiceDefinitionAttribute> serviceDefinitionAttributes) { | ||
|
|
||
| Argument<Map<String, String>> type = Argument.mapOf(String.class, String.class); | ||
| Optional<Map<String, String>> body = request.getBody(type); |
There was a problem hiding this comment.
@HootDunk After migration, I found that body was null. I suspect it is due to the following breaking change outlined in https://docs.micronaut.io/latest/guide/#_body_annotation_on_controller_parameters .
I resorted to deserializing the request body to a Map so that we have access to the attribute[attrValue] form keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required: Install Java 17