Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moveit_servo package executabe name has changed #854

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

fdurchdewald
Copy link
Contributor

The moveit_servo package executable 'servo_node_main' was renamed to 'servo_node'.

@fmauch
Copy link
Collaborator

fmauch commented Oct 20, 2023

@fdurchdewald could we also add the change for the ee_frame parameter?

diff --git a/ur_moveit_config/config/ur_servo.yaml b/ur_moveit_config/config/ur_servo.yaml
index 9802702..767481a 100644
--- a/ur_moveit_config/config/ur_servo.yaml
+++ b/ur_moveit_config/config/ur_servo.yaml
@@ -40,7 +40,7 @@ move_group_name:  ur_manipulator  # Often 'manipulator' or 'arm'
 planning_frame: base_link  # The MoveIt planning frame. Often 'base_link' or 'world'

 ## Other frames
-ee_frame_name: tool0  # The name of the end effector link, used to return the EE pose
+ee_frame: tool0  # The name of the end effector link, used to return the EE pose
 robot_link_command_frame:  tool0  # commands must be given in the frame of a robot link. Usually either the base or end effector

Otherwise the moveit_servo node also doesn't start.

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems to be the correct fix, so approving.

However, I could not get the servo thing running correctly. But that's another issue, I guess.

@fmauch fmauch merged commit c4d8d61 into UniversalRobots:main Oct 25, 2023
11 checks passed
@fmauch
Copy link
Collaborator

fmauch commented Nov 19, 2023

@Mergifyio backport Iron

Copy link

mergify bot commented Nov 19, 2023

backport Iron

❌ No backport have been created

  • Backport to branch Iron failed

GitHub error: Branch not found

@fmauch
Copy link
Collaborator

fmauch commented Nov 19, 2023

@Mergifyio backport iron

Copy link

mergify bot commented Nov 19, 2023

backport iron

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 19, 2023
* moveit_servo package changed executable name to servo_node

* ee-frame name updated

(cherry picked from commit c4d8d61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants