Properly translate attribution close label (fixes #1083) (#1126)

UniversalViewer · Oct 16, 2024 · c0fda72 · c0fda72
1 parent d39123b
commit c0fda72
Show file tree

Hide file tree

Showing 10 changed files with 32 additions and 14 deletions.
diff --git a/src/content-handlers/iiif/BaseConfig.ts b/src/content-handlers/iiif/BaseConfig.ts
@@ -153,6 +153,7 @@ export type CenterPanelOptions = {
 
 export type CenterPanelContent = {
   attribution: string;
+  close: string;
 };
 
 type CenterPanel = ModuleConfig & {

diff --git a/src/content-handlers/iiif/extensions/uv-aleph-extension/config/config.json b/src/content-handlers/iiif/extensions/uv-aleph-extension/config/config.json
@@ -199,7 +199,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "alephCenterPanel": {
@@ -211,7 +212,8 @@
         "dracoDecoderPath": "uv/lib/"
       },
       "content": {
-        "attribution": "Attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "settingsDialogue": {

diff --git a/src/content-handlers/iiif/extensions/uv-av-extension/config/config.json b/src/content-handlers/iiif/extensions/uv-av-extension/config/config.json
@@ -226,7 +226,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "avCenterPanel": {
@@ -248,6 +249,7 @@
       },
       "content": {
         "attribution": "$attribution",
+        "close": "$close",
         "currentTime": "$currentTime",
         "delimiter": " - ",
         "duration": "$duration",

diff --git a/src/content-handlers/iiif/extensions/uv-default-extension/config/config.json b/src/content-handlers/iiif/extensions/uv-default-extension/config/config.json
@@ -93,7 +93,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "fileLinkCenterPanel": {
@@ -104,7 +105,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "footerPanel": {

diff --git a/src/content-handlers/iiif/extensions/uv-ebook-extension/config/config.json b/src/content-handlers/iiif/extensions/uv-ebook-extension/config/config.json
@@ -195,7 +195,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "ebookCenterPanel": {
@@ -206,7 +207,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "settingsDialogue": {

diff --git a/src/content-handlers/iiif/extensions/uv-mediaelement-extension/config/config.json b/src/content-handlers/iiif/extensions/uv-mediaelement-extension/config/config.json
@@ -153,7 +153,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "mediaelementCenterPanel": {
@@ -167,7 +168,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "restrictedDialogue": {

diff --git a/src/content-handlers/iiif/extensions/uv-model-viewer-extension/config/config.json b/src/content-handlers/iiif/extensions/uv-model-viewer-extension/config/config.json
@@ -244,7 +244,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "modelViewerCenterPanel": {
@@ -260,6 +261,7 @@
       },
       "content": {
         "attribution": "$attribution",
+        "close": "$close",
         "zoomIn": "$zoomIn",
         "zoomOut": "$zoomOut",
         "vr": "$vr"

diff --git a/src/content-handlers/iiif/extensions/uv-openseadragon-extension/config/config.json b/src/content-handlers/iiif/extensions/uv-openseadragon-extension/config/config.json
@@ -333,7 +333,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "openSeadragonCenterPanel": {
@@ -361,6 +362,7 @@
       },
       "content": {
         "attribution": "$attribution",
+        "close": "$close",
         "goHome": "$goHome",
         "imageUnavailable": "$imageUnavailable",
         "next": "$next",

diff --git a/src/content-handlers/iiif/extensions/uv-pdf-extension/config/config.json b/src/content-handlers/iiif/extensions/uv-pdf-extension/config/config.json
@@ -171,7 +171,8 @@
         "requiredStatementEnabled": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "pdfCenterPanel": {
@@ -183,7 +184,8 @@
         "usePdfJs": true
       },
       "content": {
-        "attribution": "$attribution"
+        "attribution": "$attribution",
+        "close": "$close"
       }
     },
     "resourcesLeftPanel": {

diff --git a/src/content-handlers/iiif/modules/uv-shared-module/CenterPanel.ts b/src/content-handlers/iiif/modules/uv-shared-module/CenterPanel.ts
@@ -56,7 +56,7 @@ export class CenterPanel<
                                 <div class="attribution">
                                   <div class="header">
                                     <div class="title"></div>
-                                    <button type="button" class="close" aria-label="Close">
+                                    <button type="button" class="close">
                                       <span aria-hidden="true">&#215;</span>
                                     </button>
                                   </div>
@@ -73,6 +73,7 @@ export class CenterPanel<
     this.closeAttribution();
 
     this.$closeAttributionButton = this.$attribution.find(".header .close");
+    this.$closeAttributionButton.attr("aria-label", this.content.close);
     this.$closeAttributionButton.on("click", (e) => {
       e.preventDefault();
       this.closeAttribution();