Add aria labels to toggle expand metadata (fixes issue 1081) #1156
Conversation
Bumps [ws](https://github.com/websockets/ws) from 5.2.3 to 5.2.4. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@5.2.3...5.2.4) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…ot/npm_and_yarn/ws-5.2.4 Bump ws from 5.2.3 to 5.2.4
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@jamesmisson, I was able to resolve the conflicts here (they were caused by inconsistent indentation in a couple of the locale files). Now the Vercel build is passing! However, when I look at the preview, more buttons seem to be entirely absent, so something is broken (unless we need to wait for other component upgrades before this can work at all). |
|
I have also converted this to a draft to prevent it from getting accidentally merged before the translations are added. :-) |
|
Thanks @demiankatz . the buttons won't appear until the iiif-metadata-component changes are made and imported here (which makes testing this tricky!) |
There was a problem hiding this comment.
Thanks, @jamesmisson -- looks like a couple of things got accidentally reverted along with the whitespace changes.
src/locales/fr-FR.json
Outdated
| @@ -97,7 +99,6 @@ | |||
| "$rotateRight": "Pivoter à droite", | |||
| "$zoomIn": "Zoomer", | |||
| "$zoomOut": "Dézoomer", | |||
| "$adjustImage": "Ajuster l'image", | |||
There was a problem hiding this comment.
This seems to have been deleted by accident.
src/locales/fr-FR.json
Outdated
| @@ -116,7 +117,7 @@ | |||
| "$clickToZoomEnabled": "Cliquer pour zoomer", | |||
| "$reducedMotion": "Réduire le mouvement (désactive les animations)", | |||
| "$preserveViewport": "Conserver le zoom", | |||
| "$uvWebsite": "<a href='https://github.com/universalviewer/universalviewer#contributors'>En savoir + sur le Universal Viewer</a>", | |||
| "$uvWebsite": "<a href='https://github.com/universalviewer/universalviewer#contributors'>informations</a>", | |||
There was a problem hiding this comment.
This also seems to have been accidentally reverted.
src/locales/pl-PL.json
Outdated
| @@ -97,7 +99,6 @@ | |||
| "$rotateRight": "Obróć w prawo", | |||
| "$zoomIn": "Przybliż", | |||
| "$zoomOut": "Oddal", | |||
| "$adjustImage": "Dostosuj obraz", | |||
There was a problem hiding this comment.
This file seems to have the same two problems as the other one.
This is a fix for #1081. It defines strings for aria label prefixes and appends the label text to them (to create the text recommended in the issue comments), applying this string to each toggle button.
It's dependent on some changes to iiif-metadata-component, incorporating IIIF-Commons/iiif-metadata-component#33.
Waiting for French and Polish translations.