-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #1228
Update README.md #1228
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Saira-A This looks good to me. Let’s wait for @demiankatz feedback on the README update to see what he thinks. |
@Saira-A and @LanieOkorodudu, I like the governance link you've added! I see that you've also uncommented the Scope section. I'm not sure why that was commented out in the first place (the Git history is unfortunately not enlightening). I honestly don't really like the "Scope" heading -- not sure what it really means; I would be more inclined to call this "About" or "Project History" if it needs a heading. But more than that, I wonder if we should delete the heading entirely and just move the "about the project" link to some other section. I don't think it's the first thing most people are going to want to read about, so having it take up so much real estate so early in the document seems unhelpful. |
Thanks! I agree - I just put it back since the anchor link for it was still there but leading to nothing. Since the about section is part of the Wiki I could just link to that instead, perhaps at the top next to the Slack/Twitter links? |
Sounds like a good plan, @Saira-A -- I agree that it makes sense to just remove the scope link from the nav menu (which was probably only left there as an oversight) and add an about link at the top where you suggest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. Thanks again!
(We can merge at the meeting in 30 minutes if nobody else objects to anything). |
thanks @demiankatz |
Issue #1203 - just the governance doc for now but will add more as we get them.
Also put the 'scope' section back as it had been commented out but the anchor was still there.