Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @google/model-viewer from 1.12.1 to 4.0.0 #1287

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 20, 2025

Bumps @google/model-viewer from 1.12.1 to 4.0.0.

Release notes

Sourced from @​google/model-viewer's releases.

v4.0.0

✋Breaking Change

  • Our default tone-mapping has been updated to PBR Neutral, for improved color accuracy. If you have not been specifying tone-mapping, you'll need to either regenerate your poster images or use tone-mapping="aces" to get our legacy behavior. #4886
  • The default min and max camera-orbit have been updated to allow straight top and bottom views. #4916

Bug fixes

  • Fixed variants. #4882
  • Fixed surface hotspot updates. #4867
  • Fixed withCredentials updating. #4892
  • getCameraTarget now returns the instantaneous position, like getCameraOrbit. #4895

Examples

✨ Updated model documentation. #4776 ✨ Fixed material picking example to work in WebXR mode, thanks @​Hamidrzash! #4851

Other notable changes

  • Upgraded to Three.js r169. #4885, #4907
  • We no longer require a meta viewport tag to render at full DPR resolution. #4896
  • Moved the render fidelity comparisons out of this repo to Khronos ownership. #4779

Editor

v3.5.0

Features

🆕 Added localization API for a11y for WCAG compliance, thanks @​cybmiper! #4715 🆕 Added Khronos PBR Neutral tone mapping standard ("neutral") - "commerce" is now an alias for this. #4716, #4760

Bug fixes

  • Fixed USDZ auto-generation when changing baseColorFactor. #4690
  • Fixed progress event reason propagation, thanks @​rsleyland! #4701
  • Fixed build problems related to imports, thanks @​chamby! #4707, #4710
  • Fixed DPR for iframes. #4723
  • Fixed grounded skybox rotation. #4752
  • Fixed USDZ rotation. #4753
  • Fixed toBlob for offscreen elements. #4754
  • Improved performance when model-viewer.js loads before a 3D element is visible, thanks @​Arecsu! #4758

Examples

✨ Added example of a11y localization, thanks @​cybmiper! #4715

Other notable changes

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 20, 2025
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2025 5:37pm

@demiankatz
Copy link
Contributor

@dependabot rebase

Bumps [@google/model-viewer](https://github.com/google/model-viewer) from 1.12.1 to 4.0.0.
- [Release notes](https://github.com/google/model-viewer/releases)
- [Commits](https://github.com/google/model-viewer/commits/v4.0.0)

---
updated-dependencies:
- dependency-name: "@google/model-viewer"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@demiankatz
Copy link
Contributor

@edsilv, is the Astronaut 3-D model the correct way to test the Google Model Viewer extension? If so, I believe that this upgrade doesn't seem to break anything, but could you take a look and confirm when you have a moment? I don't want to merge based on testing the wrong thing. :-)

@edsilv
Copy link
Member

edsilv commented Jan 23, 2025

Yep. Just had a look at looks ok. The main thing for me is that the target works.

Copy link
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @edsilv, will merge now!

@demiankatz demiankatz merged commit b77a062 into dev Jan 23, 2025
8 checks passed
@demiankatz demiankatz deleted the dependabot/npm_and_yarn/dev/google/model-viewer-4.0.0 branch January 23, 2025 14:49
@demiankatz demiankatz removed the request for review from edsilv January 23, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants