Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate credits from credit string. #1004

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove duplicate credits from credit string. #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Classes/ServiceAPI/MyRadio_Creditable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,19 @@ public function getPresenterString()
$credit_types_in_byline[] = $type["value"];
}
}
$str = '';
$names = [];
foreach ($this->getCredits() as $credit) {
if (in_array($credit['type'], $credit_types_in_byline)) {
$str .= $credit['User']->getName().', ';
$names[] = $credit['User']->getName();
} else {
continue;
}
}
$names = array_unique($names);
$str = implode(", ",$names);


return empty($str) ? '' : substr($str, 0, -2);
return empty($names) ? '' : $str;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why this can't be empty($names) ? '' : implode(", ",$names)? Alternatively, what happens when implode is called on an empty array - if it's just '', could this ternary be eliminated?

}

/**
Expand Down