feat: export dependent feature toggles (#5007)

src/lib/features/dependent-features/dependent-features-read-model-type.ts

@@ -1,11 +1,13 @@
-import { IDependency } from '../../types';
+import { IDependency, IFeatureDependency } from '../../types';
+import { FeatureDependency } from './dependent-features';
 
 export interface IDependentFeaturesReadModel {
     getChildren(parents: string[]): Promise<string[]>;
     // given a list of parents and children verifies if some children would be orphaned after deletion
     // we're interested in the list of parents, not orphans
     getOrphanParents(parentsAndChildren: string[]): Promise<string[]>;
     getParents(child: string): Promise<IDependency[]>;
+    getDependencies(children: string[]): Promise<IFeatureDependency[]>;
     getParentOptions(child: string): Promise<string[]>;
     hasDependencies(feature: string): Promise<boolean>;
 }

src/lib/features/dependent-features/dependent-features-read-model.ts

@@ -1,6 +1,7 @@
 import { Db } from '../../db/db';
 import { IDependentFeaturesReadModel } from './dependent-features-read-model-type';
-import { IDependency } from '../../types';
+import { IDependency, IFeatureDependency } from '../../types';
+import { FeatureDependency } from './dependent-features';
 
 export class DependentFeaturesReadModel implements IDependentFeaturesReadModel {
     private db: Db;
@@ -43,6 +44,22 @@ export class DependentFeaturesReadModel implements IDependentFeaturesReadModel {
         }));
     }
 
+    async getDependencies(children: string[]): Promise<IFeatureDependency[]> {
+        const rows = await this.db('dependent_features').whereIn(
+            'child',
+            children,
+        );
+
+        return rows.map((row) => ({
+            feature: row.child,
+            dependency: {
+                feature: row.parent,
+                enabled: row.enabled,
+                variants: row.variants,
+            },
+        }));
+    }
+
     async getParentOptions(child: string): Promise<string[]> {
         const result = await this.db('features')
             .where('features.name', child)

src/lib/features/dependent-features/fake-dependent-features-read-model.ts

@@ -1,9 +1,13 @@
 import { IDependentFeaturesReadModel } from './dependent-features-read-model-type';
-import { IDependency } from '../../types';
+import { IDependency, IFeatureDependency } from '../../types';
+import { FeatureDependency } from './dependent-features';
 
 export class FakeDependentFeaturesReadModel
     implements IDependentFeaturesReadModel
 {
+    getDependencies(): Promise<IFeatureDependency[]> {
+        return Promise.resolve([]);
+    }
     getChildren(): Promise<string[]> {
         return Promise.resolve([]);
     }

src/lib/features/export-import-toggles/createExportImportService.ts

@@ -44,6 +44,8 @@ import {
     createPrivateProjectChecker,
 } from '../private-project/createPrivateProjectChecker';
 import { DbServiceFactory } from 'lib/db/transaction';
+import { DependentFeaturesReadModel } from '../dependent-features/dependent-features-read-model';
+import { FakeDependentFeaturesReadModel } from '../dependent-features/fake-dependent-features-read-model';
 
 export const createFakeExportImportTogglesService = (
     config: IUnleashConfig,
@@ -102,6 +104,8 @@ export const createFakeExportImportTogglesService = (
         { getLogger },
         eventService,
     );
+    const dependentFeaturesReadModel = new FakeDependentFeaturesReadModel();
+
     const exportImportService = new ExportImportService(
         {
             importTogglesStore,
@@ -123,6 +127,7 @@ export const createFakeExportImportTogglesService = (
             strategyService,
             tagTypeService,
         },
+        dependentFeaturesReadModel,
     );
 
     return exportImportService;
@@ -213,6 +218,8 @@ export const deferredExportImportTogglesService = (
             { getLogger },
             eventService,
         );
+        const dependentFeaturesReadModel = new DependentFeaturesReadModel(db);
+
         const exportImportService = new ExportImportService(
             {
                 importTogglesStore,
@@ -234,6 +241,7 @@ export const deferredExportImportTogglesService = (
                 strategyService,
                 tagTypeService,
             },
+            dependentFeaturesReadModel,
         );
 
         return exportImportService;

src/lib/features/export-import-toggles/export-import-service.ts

@@ -1,20 +1,21 @@
-import { IUnleashConfig } from '../../types/option';
+import { Logger } from '../../logger';
+import { IStrategy } from '../../types/stores/strategy-store';
+import { IFeatureToggleStore } from '../feature-toggle/types/feature-toggle-store-type';
+import { IFeatureStrategiesStore } from '../feature-toggle/types/feature-toggle-strategies-store-type';
 import {
+    IUnleashConfig,
+    IContextFieldStore,
+    IUnleashStores,
+    ISegmentStore,
+    IFeatureEnvironmentStore,
+    ITagTypeStore,
+    IFeatureTagStore,
     FeatureToggleDTO,
     IFeatureStrategy,
     IFeatureStrategySegment,
     IVariant,
-} from '../../types/model';
-import { Logger } from '../../logger';
-import { IFeatureTagStore } from '../../types/stores/feature-tag-store';
-import { ITagTypeStore } from '../../types/stores/tag-type-store';
-import { IStrategy } from '../../types/stores/strategy-store';
-import { IFeatureToggleStore } from '../feature-toggle/types/feature-toggle-store-type';
-import { IFeatureStrategiesStore } from '../feature-toggle/types/feature-toggle-strategies-store-type';
-import { IFeatureEnvironmentStore } from '../../types/stores/feature-environment-store';
-import { IContextFieldStore, IUnleashStores } from '../../types/stores';
-import { ISegmentStore } from '../../types/stores/segment-store';
-import { ExportQuerySchema } from '../../openapi/spec/export-query-schema';
+} from '../../types';
+import { ExportQuerySchema, ImportTogglesSchema } from '../../openapi';
 import {
     FEATURES_EXPORTED,
     FEATURES_IMPORTED,
@@ -27,7 +28,6 @@ import {
     FeatureStrategySchema,
     ImportTogglesValidateSchema,
 } from '../../openapi';
-import { ImportTogglesSchema } from '../../openapi/spec/import-toggles-schema';
 import User from '../../types/user';
 import { BadDataError } from '../../error';
 import { extractUsernameFromUser } from '../../util';
@@ -49,6 +49,8 @@ import { ImportPermissionsService, Mode } from './import-permissions-service';
 import { ImportValidationMessages } from './import-validation-messages';
 import { findDuplicates } from '../../util/findDuplicates';
 import { FeatureNameCheckResultWithFeaturePattern } from '../feature-toggle/feature-toggle-service';
+import { IDependentFeaturesReadModel } from '../dependent-features/dependent-features-read-model-type';
+import groupBy from 'lodash.groupby';
 
 export type IImportService = {
     validate(
@@ -105,6 +107,8 @@ export default class ExportImportService
 
     private importPermissionsService: ImportPermissionsService;
 
+    private dependentFeaturesReadModel: IDependentFeaturesReadModel;
+
     constructor(
         stores: Pick<
             IUnleashStores,
@@ -139,6 +143,7 @@ export default class ExportImportService
             | 'tagTypeService'
             | 'featureTagService'
         >,
+        dependentFeaturesReadModel: IDependentFeaturesReadModel,
     ) {
         this.toggleStore = stores.featureToggleStore;
         this.importTogglesStore = stores.importTogglesStore;
@@ -162,6 +167,7 @@ export default class ExportImportService
             this.tagTypeService,
             this.contextService,
         );
+        this.dependentFeaturesReadModel = dependentFeaturesReadModel;
         this.logger = getLogger('services/state-service.js');
     }
 
@@ -332,7 +338,10 @@ export default class ExportImportService
             if (tag.tagType) {
                 await this.featureTagService.addTag(
                     tag.featureName,
-                    { type: tag.tagType, value: tag.tagValue },
+                    {
+                        type: tag.tagType,
+                        value: tag.tagValue,
+                    },
                     extractUsernameFromUser(user),
                 );
             }
@@ -657,6 +666,7 @@ export default class ExportImportService
             featureTags,
             segments,
             tagTypes,
+            featureDependencies,
         ] = await Promise.all([
             this.toggleStore.getAllByNames(featureNames),
             await this.featureEnvironmentStore.getAllByFeatures(
@@ -672,6 +682,7 @@ export default class ExportImportService
             this.featureTagStore.getAllByFeatures(featureNames),
             this.segmentStore.getAll(),
             this.tagTypeStore.getAll(),
+            this.dependentFeaturesReadModel.getDependencies(featureNames),
         ]);
         this.addSegmentsToStrategies(featureStrategies, strategySegments);
         const filteredContextFields = contextFields
@@ -708,6 +719,19 @@ export default class ExportImportService
         const filteredTagTypes = tagTypes.filter((tagType) =>
             featureTags.map((tag) => tag.tagType).includes(tagType.name),
         );
+
+        const groupedFeatureDependencies = groupBy(
+            featureDependencies,
+            'feature',
+        );
+
+        const mappedFeatureDependencies = Object.entries(
+            groupedFeatureDependencies,
+        ).map(([feature, dependencies]) => ({
+            feature,
+            dependencies: dependencies.map((d) => d.dependency),
+        }));
+
         const result = {
             features: features.map((item) => {
                 const { createdAt, archivedAt, lastSeenAt, ...rest } = item;
@@ -741,9 +765,13 @@ export default class ExportImportService
             featureTags,
             segments: filteredSegments.map((item) => {
                 const { id, name } = item;
-                return { id, name };
+                return {
+                    id,
+                    name,
+                };
             }),
             tagTypes: filteredTagTypes,
+            dependencies: mappedFeatureDependencies,
         };
         await this.eventService.storeEvent({
             type: FEATURES_EXPORTED,