fix: archived flags without metrics do not count towards onboarding (#…

…8443)
Unleash · Oct 14, 2024 · 39fb1b5 · 39fb1b5
1 parent 735e6f0
commit 39fb1b5
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/src/lib/features/onboarding/onboarding-read-model.ts b/src/lib/features/onboarding/onboarding-read-model.ts
@@ -92,15 +92,6 @@ export class OnboardingReadModel implements IOnboardingReadModel {
             return null;
         }
 
-        const feature = await this.db('features')
-            .select('name')
-            .where('project', projectId)
-            .first();
-
-        if (!feature) {
-            return { status: 'onboarding-started' };
-        }
-
         const db = this.db;
         const lastSeen = await db
             .select(db.raw('1'))
@@ -117,8 +108,17 @@ export class OnboardingReadModel implements IOnboardingReadModel {
 
         if (lastSeen) {
             return { status: 'onboarded' };
-        } else {
-            return { status: 'first-flag-created', feature: feature.name };
         }
+
+        const feature = await this.db('features')
+            .select('name')
+            .where('project', projectId)
+            .where('archived_at', null)
+            .first();
+
+        if (!feature) {
+            return { status: 'onboarding-started' };
+        }
+        return { status: 'first-flag-created', feature: feature.name };
     }
 }