make sure to not filter client features even if oss

Unleash · Dec 19, 2024 · 59126e8 · 59126e8
1 parent 8e8bfa0
commit 59126e8
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 27 deletions.
diff --git a/src/lib/features/client-feature-toggles/client-feature-toggle-store.ts b/src/lib/features/client-feature-toggles/client-feature-toggle-store.ts
@@ -109,10 +109,6 @@ export default class FeatureToggleClientStore
 
         let query = this.db('features')
             .modify(FeatureToggleStore.filterByArchived, archived)
-            .modify(
-                FeatureToggleStore.filterByProjectsAccessibleByOss,
-                this.isOss,
-            )
             .leftJoin(
                 this.db('feature_strategies')
                     .select('*')

diff --git a/src/lib/features/feature-toggle/feature-toggle-store.ts b/src/lib/features/feature-toggle/feature-toggle-store.ts
@@ -439,16 +439,6 @@ export default class FeatureToggleStore implements IFeatureToggleStore {
             : queryBuilder.whereNull('archived_at');
     };
 
-    static filterByProjectsAccessibleByOss: Knex.QueryCallbackWithArgs = (
-        queryBuilder: Knex.QueryBuilder,
-        isOss: boolean,
-    ) => {
-        if (isOss) {
-            return queryBuilder.andWhere('project', '=', 'default');
-        }
-        return queryBuilder;
-    };
-
     rowToFeature(row: FeaturesTable): FeatureToggle {
         if (!row) {
             throw new NotFoundError('No feature flag found');

diff --git a/src/test/e2e/api/client/feature-oss.e2e.test.ts b/src/test/e2e/api/client/feature-oss.e2e.test.ts
@@ -67,16 +67,3 @@ afterAll(async () => {
     await app.destroy();
     await db.destroy();
 });
-
-describe('OSS downgrade', () => {
-    test('features created in projects other than default is not visible in client endpoint', async () => {
-        return app.request
-            .get('/api/client/features')
-            .expect('Content-Type', /json/)
-            .expect(200)
-            .expect((res) => {
-                expect(res.body.features).toHaveLength(1);
-                expect(res.body.features[0].name).toBe('my.default.toggle');
-            });
-    });
-});