Skip to content

Commit

Permalink
fix: only ask for project details if we have a project ID (#8339)
Browse files Browse the repository at this point in the history
This switches to using conditional SWR to fetch project details only
when you provide a project. This fixes an issue where we'd make
requests for `api/admin/personal-dashboard/undefined` (which will be a
404 in the future).
  • Loading branch information
thomasheartman authored Oct 2, 2024
1 parent e0ea1ff commit aa7d612
Showing 1 changed file with 11 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import useSWR from 'swr';
import { formatApiPath } from 'utils/formatPath';
import handleErrorResponses from '../httpErrorResponseHandler';
import type { PersonalDashboardProjectDetailsSchema } from 'openapi';
import { useConditionalSWR } from '../useConditionalSWR/useConditionalSWR';

export interface IPersonalDashboardProjectDetailsOutput {
personalDashboardProjectDetails?: PersonalDashboardProjectDetailsSchema;
Expand All @@ -13,7 +13,16 @@ export interface IPersonalDashboardProjectDetailsOutput {
export const usePersonalDashboardProjectDetails = (
project: string,
): IPersonalDashboardProjectDetailsOutput => {
const { data, error, mutate } = useSWR(
const { data, error, mutate } = useConditionalSWR(
Boolean(project),
{
latestEvents: [],
onboardingStatus: {
status: 'onboarding-started',
},
owners: [],
roles: [],
},
formatApiPath(`api/admin/personal-dashboard/${project}`),
fetcher,
);
Expand Down

0 comments on commit aa7d612

Please sign in to comment.